Skip to content

Ensure consistent background style for chart annotations in high contrast mode#3773

Merged
sveltifier merged 6 commits intomainfrom
feature/ensure-consistent-background-for-annotation-in-high-contrast-mode
Jan 26, 2026
Merged

Ensure consistent background style for chart annotations in high contrast mode#3773
sveltifier merged 6 commits intomainfrom
feature/ensure-consistent-background-for-annotation-in-high-contrast-mode

Conversation

@precious-onyenaucheya-ons
Copy link
Copy Markdown
Contributor

@precious-onyenaucheya-ons precious-onyenaucheya-ons commented Jan 8, 2026

What is the context of this PR?

Addresses ONSDESYS-606
This PR ensures that the point, range and reference annotation all have a consistent solid background while in high contrast mode
This was done by setting the useHTML property in the highchart configuration. I have also updated the visual tests.

How to review this PR

  • Check that all annotations have solid background on high contrast
  • Check that the visual tests are passing and nothing breaks as a result of the change

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@netlify
Copy link
Copy Markdown

netlify bot commented Jan 8, 2026

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 3b2f3a4
🔍 Latest deploy log https://app.netlify.com/projects/ons-design-system-preview/deploys/69772e1187c7ce000888f462
😎 Deploy Preview https://deploy-preview-3773--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@precious-onyenaucheya-ons precious-onyenaucheya-ons changed the title Ensure consistent background style for chart annotations in high cont… Ensure consistent background style for chart annotations in high contrast mode Jan 8, 2026
@precious-onyenaucheya-ons precious-onyenaucheya-ons added the Accessibility Issues discovered through accessibility testing label Jan 9, 2026
@precious-onyenaucheya-ons precious-onyenaucheya-ons marked this pull request as ready for review January 9, 2026 13:02
@precious-onyenaucheya-ons precious-onyenaucheya-ons requested a review from a team as a code owner January 9, 2026 13:02
@sveltifier sveltifier merged commit 918c239 into main Jan 26, 2026
14 checks passed
@sveltifier sveltifier deleted the feature/ensure-consistent-background-for-annotation-in-high-contrast-mode branch January 26, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accessibility Issues discovered through accessibility testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants