Add aria-label to Accordion Button and update documentation#3755
Merged
precious-onyenaucheya-ons merged 4 commits intomainfrom Nov 4, 2025
Merged
Conversation
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
#1377
This PR addresses the accessibility issue with accordion “Show all” and “Hide all” buttons having identical labels, which caused ambiguity for screen reader users when multiple accordion components were present on the same page.
To resolve this, two new optional parameters have been added:
These parameters allow each accordion instance to have unique and descriptive aria labels, providing better context for assistive technologies.
Default values are also included in case these parameters are not set.
How to review this PR
Checklist
This needs to be completed by the person raising the PR.