Skip to content

Limit chart data series in line with theme length#3754

Merged
precious-onyenaucheya-ons merged 6 commits intomainfrom
feature/update-chart-series-to-accept-only-6-series
Nov 4, 2025
Merged

Limit chart data series in line with theme length#3754
precious-onyenaucheya-ons merged 6 commits intomainfrom
feature/update-chart-series-to-accept-only-6-series

Conversation

@precious-onyenaucheya-ons
Copy link
Copy Markdown
Contributor

@precious-onyenaucheya-ons precious-onyenaucheya-ons commented Oct 31, 2025 •
edited
Loading

What is the context of this PR?

Addresses ONSDESYS-725

This PR introduces a limit on the number of data series supported by the chart component, based on the selected theme.

  • The primary theme now supports up to 6 series.
  • The alternate theme supports up to 5 series.

Any additional series beyond these limits will be ignored and not displayed. This is to align with the Design System’s available color palette for each theme.

How to review this PR

  • Open a chart example using both primary and alternate themes.
  • For the primary theme, add more than 6 data series — confirm that only the first 6 are rendered.
  • For the alternate theme, add more than 5 data series — confirm that only the first 5 are rendered.
  • Check that the component documentation clearly explains these theme-based limits.
  • Optionally, adjust the series count (e.g., from 4 → 7) to verify that the truncation works correctly for both themes.

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@precious-onyenaucheya-ons precious-onyenaucheya-ons added the Enhancement Change of existing feature label Oct 31, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 31, 2025 •
edited
Loading

✅ Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit a21229d
🔍 Latest deploy log https://app.netlify.com/projects/ons-design-system-preview/deploys/6909c3ee507f8c0008434134
😎 Deploy Preview https://deploy-preview-3754--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@precious-onyenaucheya-ons precious-onyenaucheya-ons marked this pull request as ready for review October 31, 2025 11:04
@precious-onyenaucheya-ons precious-onyenaucheya-ons requested a review from a team as a code owner October 31, 2025 11:04
@precious-onyenaucheya-ons precious-onyenaucheya-ons marked this pull request as draft November 3, 2025 10:15
@precious-onyenaucheya-ons precious-onyenaucheya-ons changed the title Update chart component to accept only 6 series Limit chart data series in line with theme length Nov 3, 2025
@precious-onyenaucheya-ons precious-onyenaucheya-ons marked this pull request as ready for review November 3, 2025 15:53
@precious-onyenaucheya-ons precious-onyenaucheya-ons merged commit 60707f1 into main Nov 4, 2025
14 checks passed
@precious-onyenaucheya-ons precious-onyenaucheya-ons deleted the feature/update-chart-series-to-accept-only-6-series branch November 4, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sveltifier sveltifier sveltifier approved these changes

Assignees

@precious-onyenaucheya-ons precious-onyenaucheya-ons

Labels

Enhancement Change of existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@precious-onyenaucheya-ons @sveltifier