Skip to content

Fix: Cookie banner still showing after saving cookie settings#3753

Merged
SriHV merged 10 commits intomainfrom
feature/address-issue-with-cookies-banner
Jan 29, 2026
Merged

Fix: Cookie banner still showing after saving cookie settings#3753
SriHV merged 10 commits intomainfrom
feature/address-issue-with-cookies-banner

Conversation

@precious-onyenaucheya-ons
Copy link
Copy Markdown
Contributor

@precious-onyenaucheya-ons precious-onyenaucheya-ons commented Oct 21, 2025

What is the context of this PR?

This PR fixes the issue where the cookies banner still appears after a user saves their cookie settings.
Ticket - ONSDESYS-710

How to review this PR

  1. Navigate to Patterns → Cookies Settings → Example Cookie Settings Page.
  2. Save your cookie preferences — a panel should appear confirming that your cookies have been saved.
  3. Click “Return to previous page”:
  • For Design System examples, the link should not navigate anywhere.
  • For non-Design System pages, the cookies banner should no longer appear once you return.

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@netlify
Copy link
Copy Markdown

netlify bot commented Oct 21, 2025

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit e619c69
🔍 Latest deploy log https://app.netlify.com/projects/ons-design-system-preview/deploys/697b79daefe53b000904f2da
😎 Deploy Preview https://deploy-preview-3753--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@precious-onyenaucheya-ons precious-onyenaucheya-ons added the Bug Something isn't working label Oct 21, 2025
@precious-onyenaucheya-ons precious-onyenaucheya-ons marked this pull request as ready for review October 24, 2025 10:00
@precious-onyenaucheya-ons precious-onyenaucheya-ons requested a review from a team as a code owner October 24, 2025 10:00
@precious-onyenaucheya-ons precious-onyenaucheya-ons force-pushed the feature/address-issue-with-cookies-banner branch from a3e424c to cccd870 Compare October 27, 2025 10:56
@SriHV SriHV merged commit e63b271 into main Jan 29, 2026
14 checks passed
@SriHV SriHV deleted the feature/address-issue-with-cookies-banner branch January 29, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants