Skip to content

Update primary theme for charts to improve contrast#3750

Merged
precious-onyenaucheya-ons merged 6 commits intomainfrom
feature/update-chart-theme-to-improve-contrast
Nov 3, 2025
Merged

Update primary theme for charts to improve contrast#3750
precious-onyenaucheya-ons merged 6 commits intomainfrom
feature/update-chart-theme-to-improve-contrast

Conversation

@precious-onyenaucheya-ons
Copy link
Copy Markdown
Contributor

@precious-onyenaucheya-ons precious-onyenaucheya-ons commented Oct 20, 2025

What is the context of this PR?

Addresses- ONSDESYS-632

I updated the primary theme for the chart to improve color contrast to use this
1 #206095
2 #A8BD3A
3 #871A5B
4 #F66068
5 #05341A
6 #27A0CC

This is updated in order 1-6 on every chart type except line
Line chart is updated in order 1-4,6,5

How to review this PR

  1. Test that the chart examples uses the updated theme
  2. Test that all test pass and visual tests are updated accordingly

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@precious-onyenaucheya-ons precious-onyenaucheya-ons requested a review from a team as a code owner October 20, 2025 09:47
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 20, 2025

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 4e85a50
🔍 Latest deploy log https://app.netlify.com/projects/ons-design-system-preview/deploys/690497350cc5e40007a3d84c
😎 Deploy Preview https://deploy-preview-3750--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@precious-onyenaucheya-ons precious-onyenaucheya-ons added the Accessibility Issues discovered through accessibility testing label Oct 20, 2025
Copy link
Copy Markdown
Contributor

@sveltifier sveltifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. 👍

@precious-onyenaucheya-ons precious-onyenaucheya-ons force-pushed the feature/update-chart-theme-to-improve-contrast branch from ceb0cd3 to cf9ca72 Compare October 29, 2025 15:47
@precious-onyenaucheya-ons precious-onyenaucheya-ons merged commit 9aeb20c into main Nov 3, 2025
14 of 17 checks passed
@precious-onyenaucheya-ons precious-onyenaucheya-ons deleted the feature/update-chart-theme-to-improve-contrast branch November 3, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accessibility Issues discovered through accessibility testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants