Fix extra space in class list page template#3743
Merged
precious-onyenaucheya-ons merged 9 commits intomainfrom Oct 13, 2025
Merged
Fix extra space in class list page template#3743precious-onyenaucheya-ons merged 9 commits intomainfrom
precious-onyenaucheya-ons merged 9 commits intomainfrom
Conversation
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…com:ONSdigital/design-system into fix-extra-space-in-class-list-page-template
precious-onyenaucheya-ons
approved these changes
Oct 6, 2025
SriHV
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes: #3744
ONSDESYS-711
This PR fixes a minor issue where there is an extra space rendered in the page template if the
pageColClassesandmainClassesare not set.This also addresses an issue with a variable
mainClassesis named incorrectly which means thatmainColClassescannot be setHow to review this PR
pageConfigwith and without the classes set and check the HTML for spaces in the class list.pageConfig.mainColClassessets the class as expectedChecklist
This needs to be completed by the person raising the PR.