Merged
Conversation
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…om/ONSdigital/design-system into fix/pagination-accessibility-issue
precious-onyenaucheya-ons
approved these changes
Oct 1, 2025
rmccar
reviewed
Oct 2, 2025
Contributor
|
It looks like we do have some svgs in the icon macro that return an svg that doesn't have |
Co-authored-by: rmccar <42928680+rmccar@users.noreply.github.com>
Contributor
Author
I have aria-hidden=true for all the icons which doesn't have aria labelled by. Let me if that's okay |
rmccar
reviewed
Oct 2, 2025
Co-authored-by: rmccar <42928680+rmccar@users.noreply.github.com>
rmccar
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
ONSDESYS-472
As per the ticket:
Removed "Go to" from "aria-label" attributes.
When "aria-current" is set to true a default "aria-label" will only have the text set in position variable which is
"Page " ~ currentPageIndex ~ " of " ~ totalPages(Eg When aria-current is over the 3rd page, voice over only readsPage 3 of 4instead of previousCurrent Page(Page 3 of 4))The ticket also mentions about adding "aria-hidden" to svg icons. We have this already so we don't need to make any changes to it
Also user who raised this issue used total validator to check the issue. As total validator works with a paid tier. I've used wave to test the page.
How to review this PR
Checklist
This needs to be completed by the person raising the PR.