Skip to content

Create download pattern#3730

Merged
rmccar merged 6 commits intomainfrom
create-download-pattern
Sep 19, 2025
Merged

Create download pattern#3730
rmccar merged 6 commits intomainfrom
create-download-pattern

Conversation

@rmccar
Copy link
Copy Markdown
Contributor

@rmccar rmccar commented Sep 12, 2025

What is the context of this PR?

Fixes: ONSDESYS-362

Adds a new download pattern design taken from the below Figma.

Figma: https://www.figma.com/design/JFKjGsVsUdypZ3x6gbnjNq/CU-65-Download-pattern?node-id=112-28&t=VVhOL1TMSHtq3YRQ-0

Also removes the language toggle config from the example download resources example. This was misconfigured and not adding the language toggle to the example.

How to review this PR

Test example looks as expected and follows the design in the Figma

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 12, 2025

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 756fbe7
🔍 Latest deploy log https://app.netlify.com/projects/ons-design-system-preview/deploys/68cc0db231a0f800087a43db
😎 Deploy Preview https://deploy-preview-3730--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rmccar rmccar self-assigned this Sep 12, 2025
@rmccar rmccar added the Pattern A pattern in the ONS Design System label Sep 12, 2025
@rmccar rmccar marked this pull request as ready for review September 12, 2025 08:31
@rmccar rmccar requested a review from a team as a code owner September 12, 2025 08:31
@rmccar rmccar marked this pull request as draft September 12, 2025 08:31
@rmccar rmccar marked this pull request as ready for review September 12, 2025 10:12
Copy link
Copy Markdown
Contributor

@precious-onyenaucheya-ons precious-onyenaucheya-ons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VR test is now failing, Happy to approve once that is updated

@rmccar rmccar merged commit e611072 into main Sep 19, 2025
14 of 15 checks passed
@rmccar rmccar deleted the create-download-pattern branch September 19, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Pattern A pattern in the ONS Design System

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants