Adjusted alignment of button within new grid#3724
Merged
Conversation
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rmccar
approved these changes
Sep 5, 2025
precious-onyenaucheya-ons
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
ONSDESYS-137
As per Dina's suggestion. increased height of the button to sit in the 8px grid
Removed CSS set for IE11 High Contrast mode which adjusted the button size.
I changed padding to increase the height. Small button height is changed from 32 to 36 and large button's height from 52 to 56.
How to review this PR
Inspect any of the button examples and check that button's height is rounded
Checklist
This needs to be completed by the person raising the PR.