Merged
Conversation
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rmccar
approved these changes
Jun 26, 2025
janehughes
approved these changes
Jun 26, 2025
precious-onyenaucheya-ons
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
BREAKING CHANGE
Ticket: ONSDESYS-203
Fixes: #3430
Updates class names using
toctotable-of-contentsPR #3424 updated the table of contents files to remove the
tocacronym but changing theons-js-toc-containerclass was considered a breaking change due to some documentation which instructs users to set the class on a div to contain the table of contents in some instances. This PR updates that class name so we can group the breaking changes together.This will impact the table of contents component and any page that is going to use it
To mitigate the breaking change:
Update any references of the
ons-js-toc-containerclass toons-js-table-of-contents-container.How to review this PR
ons-js-toc-container. There should be none remaining within the codebaseChecklist
This needs to be completed by the person raising the PR.