Skip to content

Conversation

@mvanzulli
Copy link
Member

@mvanzulli mvanzulli commented Mar 16, 2025

Closes #765, #766 #767

@mvanzulli mvanzulli self-assigned this Mar 16, 2025
@mvanzulli
Copy link
Member Author

Animation and plot are not deplyed in MRs docs, http://www.onsas.org/previews/PR764/examples/dragBeamReconfiguration/ is this expected and maybe we need to merge @jorgepz ?

@codecov
Copy link

codecov bot commented Mar 16, 2025

Codecov Report

Attention: Patch coverage is 97.97980% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.01%. Comparing base (32f9ffa) to head (10e1c79).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
.../dragBeamReconfiguration/dragBeamReconfiguration.m 97.72% 1 Missing ⚠️
src/utils/checkONSASFields.m 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #764      +/-   ##
==========================================
+ Coverage   90.09%   91.01%   +0.92%     
==========================================
  Files         130      131       +1     
  Lines        4945     4998      +53     
==========================================
+ Hits         4455     4549      +94     
+ Misses        490      449      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

% md<img src="../../assets/dragBeamReconfiguration/VIVilus.svg" alt="general sketch VIV case" width="450"/>
% md```
% md
% md In this case, we extend the analysis to include dynamic effects and Vortex-Induced Vibrations (VIV) on the cantilever beam, according to the formulation proposed in [Modeling vortex-induced vibrations of branched structures by coupling a 3D-corotational frame finite element formulation with wake-oscillators by Villié et al. using ONSAS](https://www.sciencedirect.com/science/article/abs/pii/S0889974624000094).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
% md In this case, we extend the analysis to include dynamic effects and Vortex-Induced Vibrations (VIV) on the cantilever beam, according to the formulation proposed in [Modeling vortex-induced vibrations of branched structures by coupling a 3D-corotational frame finite element formulation with wake-oscillators by Villié et al. using ONSAS](https://www.sciencedirect.com/science/article/abs/pii/S0889974624000094).
% md In this case, we extend the analysis to include dynamic effects and Vortex-Induced Vibrations (VIV) on the cantilever beam, according to the formulation proposed in [(Villié, et.al., 2024)](https://www.sciencedirect.com/science/article/abs/pii/S0889974624000094).

@TheChikenfly
Copy link
Collaborator

Hi all,
I went through these corrections and they look all fine to me.
Cheers,
Alexandre

@TheChikenfly TheChikenfly merged commit 1b98f89 into master Mar 17, 2025
9 checks passed
@TheChikenfly TheChikenfly deleted the mvanzulli/468-viv-revamp branch March 17, 2025 12:40
@jorgepz jorgepz restored the mvanzulli/468-viv-revamp branch March 17, 2025 18:50
@jorgepz jorgepz deleted the mvanzulli/468-viv-revamp branch March 17, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

change global VIV variables in hydroframe force to official fields in the input structs (analysissettings)

4 participants