Skip to content

Conversation

@jorgepz
Copy link
Member

@jorgepz jorgepz commented Oct 23, 2024

closes #553

@jorgepz jorgepz marked this pull request as ready for review October 23, 2024 22:32
@jorgepz jorgepz changed the title various changes complete checkFields function Oct 23, 2024
@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.20%. Comparing base (a7bbf29) to head (cd5d3e4).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/utils/checkONSASFields.m 95.00% 1 Missing ⚠️
src/vtk/crossSectionVtkSolidConnec.m 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #719      +/-   ##
==========================================
+ Coverage   89.87%   90.20%   +0.33%     
==========================================
  Files         129      129              
  Lines        4413     4411       -2     
==========================================
+ Hits         3966     3979      +13     
+ Misses        447      432      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jorgepz jorgepz merged commit c3a7a44 into master Oct 24, 2024
@jorgepz jorgepz deleted the jorge branch October 24, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check fields for otherParams struct

2 participants