Fix docs inconsistencies #713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #713 +/- ##
=======================================
Coverage 89.00% 89.00%
=======================================
Files 131 131
Lines 4504 4504
=======================================
Hits 4009 4009
Misses 495 495 ☔ View full report in Codecov by Sentry. |
mvanzulli
commented
Jun 22, 2024
jorgepz
reviewed
Jun 22, 2024
jorgepz
reviewed
Jun 22, 2024
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
jorgepz
reviewed
Jun 24, 2024
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
mvanzulli
commented
Jun 24, 2024
jorgepz
reviewed
Jun 25, 2024
jorgepz
reviewed
Jun 25, 2024
jorgepz
reviewed
Jun 25, 2024
jorgepz
reviewed
Jun 25, 2024
jorgepz
reviewed
Jun 25, 2024
jorgepz
approved these changes
Jun 25, 2024
Member
jorgepz
left a comment
There was a problem hiding this comment.
thanks Mauricio. I think this is ready to be merged after conversations are solved.
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
Member
Author
Cool, thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #704