Skip to content

various changes in added mass pendulum and more... #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jorgepz merged 12 commits into from
Dec 11, 2023
Merged

various changes in added mass pendulum and more... #678

jorgepz merged 12 commits into from
Dec 11, 2023

Conversation

@jorgepz
Copy link
Member

@jorgepz jorgepz commented Nov 28, 2023 •
edited
Loading

related to #531

@jorgepz jorgepz linked an issue Nov 28, 2023 that may be closed by this pull request
added mass implementation #531
Closed
@jorgepz jorgepz mentioned this pull request Nov 28, 2023
Closed
@codecov
Copy link

codecov bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (19a0af6) 74.83% compared to head (912fdcd) 75.04%.

❗ Current head 912fdcd differs from pull request most recent head 901fd72. Consider uploading reports for the commit 901fd72 to get more accurate results

Files Patch % Lines
examples/addedMassPendulum/addedMassPendulum.m 0.00% 44 Missing ⚠️
src/crossSections/innerDragCoefCircular.m 0.00% 2 Missing ⚠️
src/elements/frame/integFluidForce.m 92.00% 2 Missing ⚠️
examples/addedMassPendulum/windUniform.m 0.00% 1 Missing ⚠️
src/core/convergenceTest.m 50.00% 1 Missing ⚠️
src/core/timeStepIteration.m 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
+ Coverage   74.83%   75.04%   +0.21%     
==========================================
  Files         148      148              
  Lines        4940     5010      +70     
==========================================
+ Hits         3697     3760      +63     
- Misses       1243     1250       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jorgepz jorgepz changed the title trying to fix added mass pendulum varios changes in added mass pendulum and more... Dec 11, 2023
@jorgepz jorgepz marked this pull request as ready for review December 11, 2023 15:13
@jorgepz jorgepz changed the title varios changes in added mass pendulum and more... various changes in added mass pendulum and more... Dec 11, 2023
@jorgepz jorgepz removed a link to an issue Dec 11, 2023
added mass implementation #531
Closed
@jorgepz jorgepz merged commit 94e982f into master Dec 11, 2023
@jorgepz jorgepz deleted the jorgepz branch December 11, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jorgepz