Skip to content

Conversation

@mvanzulli
Copy link
Member

@mvanzulli mvanzulli commented Sep 8, 2022

This PR closes #363. Thanks to @TheChikenfly who provided the example geometric parameters and also the reference.

Validation Plots:

xy

CyR

.gitignore changes:

Since sometimes external data is required for validation examples. I released examples to save .mat files inside examples folder. Thanks to @TheChikenfly for his contributions 💯

To reproduce the validation results this repo can be used: https://github.com/mvanzulli/Reconfiguration-Beam. Thanks to @frederickgosselin and Laboratory for Multiscale Mechanics for making the code public.

@mvanzulli mvanzulli added this to the version 0.3.0 milestone Sep 8, 2022
@mvanzulli mvanzulli added the validation New validation example label Sep 8, 2022
@mvanzulli mvanzulli changed the title add reconfiguration example based on Hassani Gosselin et Al 2016 🌴 add reconfiguration example Sep 9, 2022
@mvanzulli mvanzulli marked this pull request as ready for review September 11, 2022 12:00
@mvanzulli mvanzulli requested a review from jorgepz September 11, 2022 12:00
@mvanzulli mvanzulli linked an issue Sep 11, 2022 that may be closed by this pull request
2 tasks
@mvanzulli
Copy link
Member Author

mvanzulli commented Sep 12, 2022

Can we add this example as a test problem ? It takes 20 s in my computer:

|=================================================|
|         _ _             _ _     _ _     _ _     |
|       /    /  /|   /  /       /    /  /         |
|      /    /  / |  /  /_ _    /_ _ /  /_ _       |
|     /    /  /  | /       /  /    /       /      |
|    /_ _ /  /   |/   _ _ /  /    /   _ _ /       |
|                                                 |
|-------------------------------------------------|
| Welcome to ONSAS v0.2.7.                        |
| This program comes with ABSOLUTELY NO WARRANTY. |
| Please read the COPYING.txt and README.md files |
|-------------------------------------------------|
| Solving problem:  staticReconfigurationCircle
|  - Cleaning output directory ... done. 
|                                                 |
| Analysis progress:   |0       50       100| %   |
|                      |====================|     |
| Time:   20.6 sec                                |
|                                                 |
| Iters:  avg  max | Stop by: force  disp  iters  |
|         5.9    8 |             10     0      0  |
|  - writing report file ...  done.               |
|=================================================|
warning: mkdir: directory exists
verifBoolean = 1

Copy link
Collaborator

@TheChikenfly TheChikenfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@mvanzulli
Copy link
Member Author

mvanzulli commented Sep 12, 2022

nice work!

Thanks for contributing, I think that if we add this problem into the tests, we are going to be testing all the hydrodynamic-corotational features:

  • linearAerodynamics.m : lift, drag and pitch moment (with no reconfiguration).
  • reconfigurationBeam.m: drag reconfiguration, undergoing large displacements.
  • simpleWindTurbine.m: only lift rigid dynamic motion, undergoing large rotations.

@mvanzulli mvanzulli changed the title add reconfiguration example Add reconfiguration example Sep 12, 2022
@jorgepz
Copy link
Member

jorgepz commented Sep 12, 2022

Adding this as a test is fine by me.
I would suggest using either a csv or a mat file but i guess is not needed to use both.

@mvanzulli
Copy link
Member Author

I am facing an issue with the local path to load a .mat file. I think Matlab is being executed from /home/runner/work/ONSAS.m/ONSAS.m/examples/reconfigurationBeam' and is not finding the file. There is any way to solve the path for Octave and Matlab at the same time ?

@TheChikenfly
Copy link
Collaborator

I also think it is a good idea to have this as a test
Regadring the .mat issue, I had this problem but I just pasted the vector values inside the script to have no .mat file...

Copy link
Member

@jorgepz jorgepz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

@mvanzulli
Copy link
Member Author

mvanzulli commented Sep 17, 2022

I also think it is a good idea to have this as a test Regadring the .mat issue, I had this problem but I just pasted the vector values inside the script to have no .mat file...

Thank you both for the comments, I've solved it exporting a .mat from matlab with the flag "-mat7-binary"

@mvanzulli
Copy link
Member Author

I am facing an issue with the local path to load a .mat file. I think Matlab is being executed from /home/runner/work/ONSAS.m/ONSAS.m/examples/reconfigurationBeam' and is not finding the file. There is any way to solve the path for Octave and Matlab at the same time ?

I solved this by adding to path both, src and the example folder:

addpath( genpath( [ pwd '/../../src'] ) ); 
addpath( genpath( [ pwd ] ) ); 

@mvanzulli mvanzulli requested a review from jorgepz September 17, 2022 16:03
@mvanzulli mvanzulli changed the title Add reconfiguration example Add reconfiguration example to C.I Sep 17, 2022
@mvanzulli mvanzulli changed the title Add reconfiguration example to C.I Add reconfiguration example to C.I 🌀 Sep 17, 2022
@mvanzulli
Copy link
Member Author

left some comments

Done

mvanzulli and others added 6 commits September 19, 2022 15:02
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
@mvanzulli mvanzulli requested a review from jorgepz September 19, 2022 19:11
@mvanzulli mvanzulli merged commit 933bf66 into master Sep 19, 2022
@jorgepz jorgepz deleted the mvanzulli/reconfiguration branch September 19, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validation New validation example

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add aerodynamic tangent matrix

4 participants