Closed
Conversation
Move it away from http2 to generic core crate. And use it for DCERPC (and SMB) And remove the C version. Main change in API is the free function is not free itself, but a rust wrapper around unbox. Ticket: OISF#4112
So as not to recompile every C file inclusing rust.h
Codecov Report
@@ Coverage Diff @@
## master #7461 +/- ##
==========================================
- Coverage 75.88% 75.81% -0.07%
==========================================
Files 657 655 -2
Lines 189473 188471 -1002
==========================================
- Hits 143775 142892 -883
+ Misses 45698 45579 -119
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
ERROR: ERROR: QA failed on tlpw1_files_sha256. ERROR: QA failed on tlpr1_alerts_cmp. Pipeline 7634 |
Merged
Member
|
Merged in #7467, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4112
https://redmine.openinfosecfoundation.org/issues/2697
Describe changes:
DetectUintstructure fordsizeanddcerpc,ttl,tcpmss,filesize,streamsize(and template2)Replaces #7357 with rebase and adding S-V PR for missing keywords
Further work, but this PR can already be merged:
set_uintin loggers to see if we can easily a new keywordssuricata-verify-pr: 839