Skip to content

Introduce support for InterSystems IRIS#2416

Merged
chrisknoll merged 12 commits intoOHDSI:masterfrom
intersystems-community:master
Feb 25, 2025
Merged

Introduce support for InterSystems IRIS#2416
chrisknoll merged 12 commits intoOHDSI:masterfrom
intersystems-community:master

Conversation

@bdeboe
Copy link
Contributor

@bdeboe bdeboe commented Dec 4, 2024

This PR introduces support for InterSystems IRIS Data Platform as a new platform, including the SqlRender and Arachne library updates adding IRIS support

Fixes #2409

Copy link
Collaborator

@anthonysena anthonysena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks fine from a functional perspective. I'd like to update this PR to note that this is 'tentative' support for IRIS based on SqlRender's release notes. I'd also like to document how a user obtains the JDBC driver and installs it configure WebAPI to use IRIS.

@bdeboe
Copy link
Contributor Author

bdeboe commented Jan 2, 2025

Thanks for taking a look at this @anthonysena

If you could please let me know where I can appropriately document how to get the drivers I'll do that right away.

Thanks & happy 2025!

@alex-odysseus alex-odysseus self-requested a review January 8, 2025 13:31
@alex-odysseus
Copy link
Contributor

Benjamin, please create a pull request to the Atlas repository from your company repository https://github.com/intersystems-community/OHDSI-Atlas/commits/master/
Anthony, I think we are good to merge
@bdeboe @anthonysena

@bdeboe
Copy link
Contributor Author

bdeboe commented Jan 28, 2025

Hi @anthonysena , I believe we addressed your questions, so hopefully this is now ready for acceptance?
Thanks!

@bdeboe
Copy link
Contributor Author

bdeboe commented Feb 10, 2025

Hi @anthonysena , anything our team can do to help progress this?
Thanks!

@bdeboe
Copy link
Contributor Author

bdeboe commented Feb 24, 2025

Hi @anthonysena,
any chance you can look into this? We're promoting the use of Atlas/WebAPI, including through BroadSea, and having this be part of the master repo would be a great help.
Thanks in advance!
benjamin

Copy link
Collaborator

@anthonysena anthonysena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bdeboe these changes look good from my perspective. I know @chrisknoll is also going to review so we'll give him some time to take a look.

@chrisknoll chrisknoll merged commit d4dc8a5 into OHDSI:master Feb 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add IRIS support to WebAPI

4 participants