Skip to content

Non-Standard to Standard Concepts mapping API#2407

Merged
chrisknoll merged 5 commits intomasterfrom
concepts-mapping
Feb 18, 2025
Merged

Non-Standard to Standard Concepts mapping API#2407
chrisknoll merged 5 commits intomasterfrom
concepts-mapping

Conversation

@alex-odysseus
Copy link
Contributor

Addressing #2348

Adding an endpoint to get Standard Concepts into which non-Standard Concepts can be mapped

The Related Concepts SQL statement has been used as the basis

Copy link
Collaborator

@anthonysena anthonysena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a question regarding the query you are using to get the related concepts but otherwise seems good.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This query seems a bit off - why does it require a GROUP BY when there is no aggregation done in the outermost query? Should the 1 as RELATIONSHIP_DISTANCE be summed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could work the same as a select distinct...

@chrisknoll chrisknoll merged commit 17cbf89 into master Feb 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-Standard Concepts mapped to Standard Concepts to be replaced by Standard Concepts by the "Optimize" functionality of a Concept Set

4 participants