Merged
Conversation
blootsvoets
reviewed
Mar 15, 2021
Comment on lines
+449
to
+450
| replaceButton.setEnabled(true); | ||
| addButtons.forEach(x -> x.setEnabled(true)); |
Collaborator
There was a problem hiding this comment.
I notice that the buttons do not seem to get disabled anywhere. Not sure if that's intentional.
Collaborator
Author
There was a problem hiding this comment.
They are disabled here:
Usagi/src/org/ohdsi/usagi/ui/MappingDetailPanel.java
Lines 178 to 181 in e11d4b0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug where add buttons not being enabled if code unapproved.
And the unit/value target type selections are now moved to the left of the button panels.