Skip to content

Review workflow#105

Merged
MaximMoinat merged 86 commits intoOHDSI:developfrom
EHDEN:review-workflow
Mar 11, 2021
Merged

Review workflow#105
MaximMoinat merged 86 commits intoOHDSI:developfrom
EHDEN:review-workflow

Conversation

@MaximMoinat
Copy link
Copy Markdown
Collaborator

@MaximMoinat MaximMoinat commented Feb 10, 2021 •
edited
Loading

New features:

  • Flag status (from map-variables branch)
  • Provenance, author and timestamp (from map-variables branch)
  • Equivalence
  • Random reviewer assignment
  • Minor other updates to support review workflow

Todo:

  • Give list of reviewers to the reviewer assignment
  • Evenly divide codes between reviewers
  • Filtering of code list by reviewer

Maxim Moinat added 30 commits October 1, 2020 09:43
add mapping type for target concepts
ac2f228
add buttons for each mapping type
7a2f336
read mappingtype from save file
8e363da
do not display regular on button
b7d9b08
add ignored status and button to toggle
f5569f5
add toggling of ignore button
c1727d3
refactor approve actions and add ignoreSelected
faafae8
refactor clear all to clear selected
b879adb
clear existing mappings if status set to ignored
407304a
set rendering of ignored rows grey text on white
66ecd58
prevent approving of ignored and ignoring of approved mappings
8545396
render background of ignored rows as normal
9cc0655
Merge pull request OHDSI#92 from OHDSI/target-types
d95490e 
Target types
Merge branch 'map-variables' into ignore-status
22e0e1a
Merge pull request OHDSI#93 from OHDSI/ignore-status
fdcb9f1 
New 'Ignored' status
add author and time details to mappings
8f89c98
simplify approve/ignore author and date
026a720
assign concept added by as <auto> upon import
3dc5be4
save and load provenance fields
682e13d
format provenance
fc3aee5
change order of fields in usagi save file
9ca258f
refactor ImportDialog
cd1a3e5
read value code, value name and unit on import
bef371c
display new source code attributes
cc2f99c
frequency at the end in source code panel
c89b8dd
allow auto querying by value or unit name
b05afe8
make value and unit fields optional in Usagi save file
92916a1
display term, value, unit toggle properly
396db8e
flag button
9ce9245
toggle flag button upon ignore and approve
649a298
@MaximMoinat MaximMoinat marked this pull request as ready for review February 17, 2021 12:59
blootsvoets
blootsvoets reviewed Feb 17, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@blootsvoets blootsvoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine in general. I have some questions about the data classes and the row mapper. Other than that I didn't test the UI.

@MaximMoinat
Copy link
Copy Markdown
Collaborator Author

MaximMoinat commented Feb 19, 2021 •
edited
Loading

Additional features to be added after first round of testing:

  • Set equivalence information also when flagging a mapping
  • Reset equivalence to UNREVIEWED when unapproved or unflagged
  • Assign reviewers only to selected rows.
  • (optional) Add in mapping types for target concepts: EVENT, VALUE and UNIT for "Maps to", "Maps to value" and "Maps to unit" respectively. EVENT is the default type.

@mik-ohdsi Sounds good?

@MaximMoinat MaximMoinat merged commit 3fcbbb8 into OHDSI:develop Mar 11, 2021
@MaximMoinat MaximMoinat deleted the review-workflow branch August 15, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blootsvoets blootsvoets blootsvoets approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaximMoinat @blootsvoets