Skip to content

Temporal annual distribution functionality#46

Merged
chrisknoll merged 13 commits intomasterfrom
temporal-annual-distribution
Mar 25, 2025
Merged

Temporal annual distribution functionality#46
chrisknoll merged 13 commits intomasterfrom
temporal-annual-distribution

Conversation

@alex-odysseus
Copy link
Contributor

@alex-odysseus alex-odysseus commented Aug 28, 2024

Supporting OHDSI/WebAPI#2331 to enable temporal annual distribution extending the existing temporal functionality

As FeatureExtraction has the temporal functionality available for a while there was an intention to enable it in Cohort Characterization WebAPI / ATLAS functionality together with a newly requested temporal annual distribution functionality

Targeting the new functionality for 2.0.0

wivern and others added 7 commits February 21, 2024 19:05
Changed versions of libraries, excluded circe from specs to avoid runtime exceptions due do version conflicts
…3.7.0-SNAPSHOT where temporal annual distribution functionality is targeted
oleg-odysseus and others added 3 commits February 25, 2025 15:05
…ryBuilder

# Conflicts:
#	inst/java/SkeletonCohortCharacterization-2.0.0-SNAPSHOT.jar
…re temporal annual distribution functionality is targeted
@oleg-odysseus
Copy link
Contributor

@chrisknoll @anthonysena, Since FeatureExtraction 3.8.0-SNAPSHOT was successfully merged into develop, SkeletonCohortCharacterization is the next one on our way to building WebAPI for the same feature. Please kindly merge this one if we don't need to wait FeatureExtraction 3.8.0 to be released without referencing it's snapshot version here and in WebAPI. Thank you.

@alex-odysseus
Copy link
Contributor Author

We should wait for the official 3.8.0 version release, afterwards we should release 2.0.0 of the skeleton, then referencing both in WebAPI ‘master’

@oleg-odysseus
Copy link
Contributor

@chrisknoll , @anthonysena As I see FeatureExtraction 3.8.0 was successfully released and has an appropriate tag 3.8.0. Could you please do a similar release of SkeletonCohortCharacterization with the changes in this pull request, as was mentioned by @alex-odysseus in the previous comment? Thank you.

@chrisknoll
Copy link
Contributor

chrisknoll commented Mar 24, 2025

Before we do this, we have a relase of circe (v1.12.1) and I think we should look at what the conflicting dependencies are and maybe we can address one of the things added here which was excluding deps from circe?

@oleg-odysseus

@chrisknoll chrisknoll merged commit 8d6048a into master Mar 25, 2025
@chrisknoll chrisknoll deleted the temporal-annual-distribution branch March 25, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants