Data Sources reports bug fixes#2972
Merged
chrisknoll merged 3 commits intoOHDSI:masterfrom Nov 5, 2024
Merged
Conversation
chrisknoll
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 different UI bugs that I have encountered in using the Atlas Data Sources reports.
If the request to get the data for a report for some reason returns an empty array, the tabular view showed a perpetual spinner. I have update the TreeMap.js code to set the tableData parameter to an empty array in this case so that the code that turns off the spinner has an opportunity to execute.
The frequency distribution report failed to display because there was a bug in how the chart's x-axis label is generated. A recent PR changed the
parseFrequencyDistributionfunction signature so that it now passes in a string, rather than a function, for thereportparameter. (https://github.com/OHDSI/Atlas/pull/2806/files#diff-ea4bfc7a6c32110ea437c23665e2c52aea4d576102f87d5f808e40eead045176L284)