Adds ability to disable browser check via config#2863
Merged
chrisknoll merged 1 commit intoOHDSI:masterfrom May 23, 2023
Merged
Adds ability to disable browser check via config#2863chrisknoll merged 1 commit intoOHDSI:masterfrom
chrisknoll merged 1 commit intoOHDSI:masterfrom
Conversation
chrisknoll
approved these changes
May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #2845: adds a config setting named "disableBrowserCheck", which will default to false (meaning, run the browser check and toggle the warning if not a supported browser). Setting this to true will disable the browser check and warning.
To do this, I removed the existing BrowserDetection JS script and instead have a knockout data bind that runs toggleBrowserWarning() to handle this decision.