Add selection of inclusion rule permutations in Intersection View #2726 #2735
Add selection of inclusion rule permutations in Intersection View #2726 #2735chrisknoll merged 7 commits intomasterfrom
Conversation
|
The only comment I have is: the default selection of the inclusion rule filter is to specify 'any' that has 'passed'. It should default to 'all' that have 'passed', because that's the default view that people are interested in., which also matches the 'matched' statistic at the top of the report. |
|
I take it back, I played with this locally and when you set it to 'all passed' by default, the only box that lights up is the 'all passed' box (makes sense, right??) Instead, 'any passed' makes sense from a backwards-compatable perspective, because each box represents a case where at least 1 passed, so the visualization looks the same between versions when you start with 'any'. So, we'll leave it with any, unless we get some feedback where the 'all' default makes sense such that only the lit part of the graph represents the 'matching' population,....I honestly could go either way, but i'll change it back to 'any' because it makes the visualization look the same by default. |
|
@anton-abushkevich , I've pushed up a commit as a suggestion on some restructuring of the code. I noticed the use of subscriptions and the need to call out to
Those are the main changes. I'm sorry to push directly into your branch, but I wanted to try to present a best practice when dealing with databinding and observables. If you have any objections, we can always revert this commit and come at it a different way. |
Add afterRender hook to populationTreemap.
6132468 to
ea72368
Compare
|
Sorry about the force push (it was a quick bugfix I made in the loop of rectangles). It shouldn't impact you. |
Resolves #2726