Fixed invalid redirect for /atlas without trailing slash#2700
Merged
leeevans merged 1 commit intoOHDSI:masterfrom Jul 14, 2022
Merged
Fixed invalid redirect for /atlas without trailing slash#2700leeevans merged 1 commit intoOHDSI:masterfrom
leeevans merged 1 commit intoOHDSI:masterfrom
Conversation
Contributor
Author
|
I didn't want to overload this PR by adding too much, but I would be happy to add a basic E2E test (using eg https://playwright.dev/) to at least make sure that the UI loads correctly. |
97ed221 to
6a27b93
Compare
leeevans
approved these changes
Jul 14, 2022
|
@chgl - please create a separate PR if you would like to add a basic E2E test. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2641
When accessing the Atlas UI on a URL not ending in a trailing slash, NGINX would always automatically redirect you to
host:8080/atlas/.This change modifies the default NGINX configuration to use the host header for redirection.