Conversation
|
LGTM
|
| "links": [ | ||
| { | ||
| "href": "http://127.0.0.1:8774/v2/", | ||
| "rel": "self" |
There was a problem hiding this comment.
|
Please don't merge until we sort out the |
|
@fehguy Do we still need to sort-out
|
|
|
|
Responses Object keys must be quoted:
|
|
@darrelmiller Do you want to update the PR to address @webron's and @MikeRalphson's feedback, or would you like them to submit PRs? |
|
TDC: @darrelmiller has a few edits for this and will comment when ready. |
|
Issues have been addressed. I'm going to be reckless and merge this without @OAI/tdc confirmation, because it doesn't affect the spec directly. |
|
And yet, I completely missed fixing the things I was supposed to be fixing. PSA: Don't merge PRs without at least two cups of coffee first. |
|
Should this be reverted then? |
|
@webron Nah. The changes are good, they are just not complete. I've almost finished doing the rest of the changes in a new PR |
No description provided.