Skip to content

feat: update Vietnamese localizations#109

Merged
Nyasami merged 8 commits into
Nyasami:mainfrom
Astear17:main
Apr 24, 2026
Merged

feat: update Vietnamese localizations#109
Nyasami merged 8 commits into
Nyasami:mainfrom
Astear17:main

Conversation

@Astear17

Copy link
Copy Markdown
Contributor

some of the Vietnamese localizations is optimized for better understanding idk

Comment thread Ksign/Resources/Localizable.xcstrings Outdated
Comment thread Ksign/Resources/Localizable.xcstrings Outdated
Comment thread Ksign/Resources/Localizable.xcstrings Outdated
Comment thread Ksign/Resources/Localizable.xcstrings Outdated
Comment thread Ksign/Resources/Localizable.xcstrings Outdated
Comment thread Ksign/Resources/Localizable.xcstrings Outdated
Comment thread Ksign/Resources/Localizable.xcstrings Outdated
Comment thread Ksign/Resources/Localizable.xcstrings
Comment thread Ksign/Resources/Localizable.xcstrings Outdated
@Astear17 Astear17 requested a review from Nyasami April 22, 2026 10:57
@Astear17

Copy link
Copy Markdown
Contributor Author

it should be resolved after you have done all these decision

@Nyasami

Nyasami commented Apr 22, 2026

Copy link
Copy Markdown
Owner

change to IPA and its good

@Astear17 Astear17 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modify iPA and it's ready to push

@Astear17

Astear17 commented Apr 24, 2026

Copy link
Copy Markdown
Contributor Author

46b9635 needs final review

@Astear17

Copy link
Copy Markdown
Contributor Author

about 5289c8f, please add a webhook that notify to a new notification channel at section #updates called #ksign-updates in the Khoindvn server (not the Ksign support one). This was a request, u can either accept or decline this commit.

@Nyasami

Nyasami commented Apr 24, 2026

Copy link
Copy Markdown
Owner

about 5289c8f, please add a webhook that notify to a new notification channel at section #updates called #ksign-updates in the Khoindvn server (not the Ksign support one). This was a request, u can either accept or decline this commit.

no

Comment thread .github/workflows/beta.yml Outdated
Comment thread .github/workflows/beta.yml Outdated
Astear17 and others added 2 commits April 24, 2026 18:12
Co-authored-by: Nagata Asami <80683081+Nyasami@users.noreply.github.com>
Co-authored-by: Nagata Asami <80683081+Nyasami@users.noreply.github.com>
@Astear17 Astear17 requested a review from Nyasami April 24, 2026 11:13
@Nyasami Nyasami changed the title optimize Vietnamese localizations feat: update Vietnamese localizations Apr 24, 2026
@Nyasami Nyasami merged commit ce4702f into Nyasami:main Apr 24, 2026
@Nyasami

Nyasami commented Apr 24, 2026

Copy link
Copy Markdown
Owner

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants