Skip to content

List package uses aliases as pivot when printing packages; Fix list package not supporting aliased frameworks #7146

Merged
nkolev92 merged 5 commits intodevfrom
dev-nkolev92-listAliasing
Mar 12, 2026
Merged

List package uses aliases as pivot when printing packages; Fix list package not supporting aliased frameworks #7146
nkolev92 merged 5 commits intodevfrom
dev-nkolev92-listAliasing

Conversation

@nkolev92
Copy link
Copy Markdown
Member

@nkolev92 nkolev92 commented Feb 17, 2026

Bug

Fixes: NuGet/Home#14762
Fixes: NuGet/Home#14339
Fixes: NuGet/Home#14805

Description

Design at NuGet/Home#14786.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc. The list package format is not documented, so no update to be done. This raises something questions.

@nkolev92 nkolev92 force-pushed the dev-nkolev92-listAliasing branch from 5c3f837 to df1a65f Compare February 23, 2026 18:52
@dotnet-policy-service dotnet-policy-service bot added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Mar 2, 2026
@dotnet-policy-service dotnet-policy-service bot removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Mar 3, 2026
@nkolev92 nkolev92 force-pushed the dev-nkolev92-listAliasing branch 4 times, most recently from f1363d0 to 4bba788 Compare March 10, 2026 22:37
@nkolev92 nkolev92 force-pushed the dev-nkolev92-listAliasing branch from 4bba788 to 63e7f88 Compare March 10, 2026 22:38
@nkolev92 nkolev92 marked this pull request as ready for review March 10, 2026 23:38
@nkolev92 nkolev92 requested a review from a team as a code owner March 10, 2026 23:38
@nkolev92 nkolev92 requested review from jeffkl and martinrrm March 10, 2026 23:38
Copy link
Copy Markdown
Contributor

@jeffkl jeffkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

Comment thread src/NuGet.Core/NuGet.CommandLine.XPlat/Strings.resx Outdated
Comment thread test/NuGet.Core.FuncTests/NuGet.XPlat.FuncTest/ListPackageTests.cs Outdated
Comment thread test/NuGet.Core.Tests/NuGet.CommandLine.Xplat.Tests/MSBuildAPIUtilityTests.cs Outdated
@nkolev92 nkolev92 requested a review from jeffkl March 11, 2026 22:34
jeffkl
jeffkl previously approved these changes Mar 11, 2026
@nkolev92
Copy link
Copy Markdown
Member Author

@jeffkl Fixed the integration test error.

Can I get another review?

@nkolev92 nkolev92 enabled auto-merge (squash) March 12, 2026 18:46
@nkolev92 nkolev92 merged commit b8bbe4b into dev Mar 12, 2026
17 of 18 checks passed
@nkolev92 nkolev92 deleted the dev-nkolev92-listAliasing branch March 12, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants