Conversation
zivkan
approved these changes
Jan 10, 2026
nkolev92
approved these changes
Jan 12, 2026
donnie-msft
approved these changes
Jan 12, 2026
This was referenced Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was generated by the VS Perf Rel AI Agent. Please review this AI-generated PR with extra care! For more information, visit our wiki. Please share feedback with TIP Insights
Issue: In
ContentFileUtils.GetContentFileGrouptheresultslist is initialized withcontentFileGroups.Countas capacity, but the actual number of items added equalsentryMappings.Count(which is the count of unique file paths across all groups). Since each content group typically contains multiple items,entryMappings.Countis significantly larger thancontentFileGroups.Count, causing repeated list resizing and unnecessaryLockFileContentFile[]allocations.Evidence:
Issue type: Specify an up-front capacity for collections if one is known
Proposed fix: Move the
resultslist initialization to after theentryMappingsdictionary is fully populated, and change the capacity fromcontentFileGroups.CounttoentryMappings.Count. This ensures the list is allocated with the exact required capacity, eliminating all resize-triggered array allocations.Best practices wiki
See related failure in PRISM
ADO work item