Conversation
… list resizing based allocations
kartheekp-ms
approved these changes
Jan 7, 2026
zivkan
approved these changes
Jan 7, 2026
This was referenced Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was generated by the VS Perf Rel AI Agent. Please review this AI-generated PR with extra care! For more information, visit our wiki. Please share feedback with TIP Insights
TypeAllocated!NuGet.LibraryModel.LibraryDependency[]with frames showingList<T>.EnsureCapacity/set_Capacity, which indicates repeated List backing-array growth.In
DependencyGraphResolver.DependencyGraphItem.cs, methodDependencyGraphResolver.DependencyGraphItem.GetGraphItemAsync, the new list is created with an incorrect capacity due to operator precedence:new(capacity: RuntimeDependencies?.Count ?? 0 + item.Data.Dependencies.Count)Because
+binds tighter than??, whenRuntimeDependenciesis non-null the capacity becomes justRuntimeDependencies.Count(ignoringitem.Data.Dependencies.Count), causing predictable resizing andLibraryDependency[]allocations as items are added.new(capacity: (RuntimeDependencies?.Count ?? 0) + item.Data.Dependencies.Count)is a trivial, localized change with minimal risk and directly addresses the hot-path allocations.Best practices wiki
See related failure in PRISM
ADO work item