Fix nuget.exe restore finding MSBuild from SSMS instead of Visual Studio#6530
Merged
Fix nuget.exe restore finding MSBuild from SSMS instead of Visual Studio#6530
nuget.exe restore finding MSBuild from SSMS instead of Visual Studio#6530Conversation
nkolev92
reviewed
Jul 3, 2025
Member
nkolev92
left a comment
There was a problem hiding this comment.
Changes look good to me, but tagging @rainersigwald in case he has any suggestions here.
I think the test failures are infrastructure and not something from your PR.
Contributor
rainersigwald
left a comment
There was a problem hiding this comment.
Would this exclude Build Tools?
Contributor
Author
Build Tools also uses the |
Contributor
|
@bdukes please rebase your branch, our CI was failing last week and is fixed now. |
donnie-msft
approved these changes
Jul 8, 2025
903ca48 to
c105acc
Compare
Contributor
Author
done |
c105acc to
d702e42
Compare
zivkan
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14349
Description
SQL Server Management Studio (SSMS) 21 is now managed using the Visual Studio Installer, which causes its version of MSBuild to get picked up as an SXS toolset to use by
nuget.exe. This PR uses the Installation Name of the SXS toolset to determine whether it's a Visual Studio product or not, and thereby exclude SSMS from the considered options.PR Checklist