Onboard Package Source Mapping page to Unified Settings#6523
Merged
donnie-msft merged 9 commits intodevfrom Jun 27, 2025
Merged
Onboard Package Source Mapping page to Unified Settings#6523donnie-msft merged 9 commits intodevfrom
donnie-msft merged 9 commits intodevfrom
Conversation
JoshuaBStevens
approved these changes
Jun 26, 2025
jeffkl
reviewed
Jun 26, 2025
src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/Options/PackageSourceMappingPage.cs
Show resolved
Hide resolved
src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/Options/PackageSourceMappingUtility.cs
Show resolved
Hide resolved
jeffkl
previously approved these changes
Jun 26, 2025
nkolev92
reviewed
Jun 26, 2025
src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/Options/PackageSourceMappingUtility.cs
Show resolved
Hide resolved
src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/Options/PackageSourceMappingUtility.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/Options/PackageSourceMappingUtility.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/Options/PackageSourceMappingUtility.cs
Outdated
Show resolved
Hide resolved
...nts.Tests/NuGet.PackageManagement.VisualStudio.Test/Options/PackageSourceMappingPageTests.cs
Outdated
Show resolved
Hide resolved
...nts.Tests/NuGet.PackageManagement.VisualStudio.Test/Options/PackageSourceMappingPageTests.cs
Show resolved
Hide resolved
jeffkl
approved these changes
Jun 27, 2025
nkolev92
approved these changes
Jun 27, 2025
Member
nkolev92
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback and adding the tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14234
Fixes: NuGet/Home#13355
Fixes: NuGet/Home#13150
Fixes: NuGet/Home#13115
Fixes: NuGet/Home#13520
Fixes: https://github.com/NuGet/Client.Engineering/issues/2426
Fixes: https://github.com/NuGet/Client.Engineering/issues/1944
Description
Onboards the Package Source Mapping page to Unified Settings.
?beside the page titleSetValueAsync_PreviousMappingsToNonexistantSources_AddNewMapping_ExistingMappingsAreUnchangedAsyncis important as it highlights the behavior of VS not deleting any misconfigured Package Source Mappings.We may want to revisit this behavior, but I didn't want to change that as part of the onboarding. It could be something customers are relying on today.
Side-effects
Remove All command is not available at this time because the behavior of USX is an immediate action, which may result in customers accidentally permanently deleting all source mappings with 1 click. Telemetry shows this command was used very little in Legacy Options compared to add/remove commands.
"Configure" link from PM UI Details Pane no longer auto-selects the Source Mapping for the selected package. USX doesn't yet support this functionality.
Related bugs (not being addressed)
These bugs will not be fixed, but they will have a change in behavior:
PR Checklist