Skip to content

Onboard Package Source Mapping page to Unified Settings#6523

Merged
donnie-msft merged 9 commits intodevfrom
dev-donnie-msft-usxPackageSourceMappingPage
Jun 27, 2025
Merged

Onboard Package Source Mapping page to Unified Settings#6523
donnie-msft merged 9 commits intodevfrom
dev-donnie-msft-usxPackageSourceMappingPage

Conversation

@donnie-msft
Copy link
Contributor

@donnie-msft donnie-msft commented Jun 25, 2025

Bug

Fixes: NuGet/Home#14234
Fixes: NuGet/Home#13355
Fixes: NuGet/Home#13150
Fixes: NuGet/Home#13115
Fixes: NuGet/Home#13520
Fixes: https://github.com/NuGet/Client.Engineering/issues/2426
Fixes: https://github.com/NuGet/Client.Engineering/issues/1944

Description

Onboards the Package Source Mapping page to Unified Settings.

  • New functionality: Editing an existing Package Source Mapping is now supported.
  • F1 Help link now appears as a ? beside the page title
  • Existing legacy options logic has been tucked away into a PackageSourceMappingUtility.
  • The unit test SetValueAsync_PreviousMappingsToNonexistantSources_AddNewMapping_ExistingMappingsAreUnchangedAsync is important as it highlights the behavior of VS not deleting any misconfigured Package Source Mappings.
    We may want to revisit this behavior, but I didn't want to change that as part of the onboarding. It could be something customers are relying on today.

image

image
image

Side-effects

  • Remove All command is not available at this time because the behavior of USX is an immediate action, which may result in customers accidentally permanently deleting all source mappings with 1 click. Telemetry shows this command was used very little in Legacy Options compared to add/remove commands.

  • "Configure" link from PM UI Details Pane no longer auto-selects the Source Mapping for the selected package. USX doesn't yet support this functionality.

Related bugs (not being addressed)

These bugs will not be fixed, but they will have a change in behavior:

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@donnie-msft donnie-msft requested a review from a team as a code owner June 25, 2025 23:33
@donnie-msft donnie-msft requested review from jeffkl and martinrrm June 25, 2025 23:33
@donnie-msft donnie-msft requested a review from jeffkl June 26, 2025 17:17
jeffkl
jeffkl previously approved these changes Jun 26, 2025
@donnie-msft donnie-msft enabled auto-merge (squash) June 27, 2025 15:24
Copy link
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback and adding the tests!

@donnie-msft donnie-msft merged commit 7fa0177 into dev Jun 27, 2025
17 of 18 checks passed
@donnie-msft donnie-msft deleted the dev-donnie-msft-usxPackageSourceMappingPage branch June 27, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants