Merged
Conversation
nkolev92
previously approved these changes
May 30, 2025
zivkan
commented
Jun 1, 2025
nkolev92
reviewed
Jun 2, 2025
nkolev92
approved these changes
Jun 2, 2025
Collaborator
|
Could you please expand in the PR description why some packages were moved from lib to ref? |
aortiz-msft
approved these changes
Jun 3, 2025
Collaborator
aortiz-msft
left a comment
There was a problem hiding this comment.
I'm approving with a comment to improve the PR description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14342
Description
Update MSBuild package versions to ones that don't have known vulnerabilities.
None of our tests running on netcoreapp3.1 or net5.0 need msbuild packages, so they were removed.
NuGet.Build.Tasks.Pack needed a change to its ILMerge config to use the package's ref assemblies, because the later versions of MSBuild don't ship
lib/netsandard2.0/*assemblies. Note, we never merged MSBuild into NuGet.Build.Tasks.Pack.dll, but ILMerge still wants to be able to find the assemblies for "compile time" validation.PR Checklist
Added testsN/ALink to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.