Merged
Conversation
jeffkl
reviewed
May 15, 2025
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/DGSpecFactory.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/DGSpecFactory.cs
Show resolved
Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/DGSpecFactory.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/PackageUpdateCommandRunner.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/PackageUpdateCommandRunner.cs
Show resolved
Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/PackageUpdateCommandRunner.cs
Show resolved
Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/PackageUpdateCommandRunner.cs
Show resolved
Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/VersionChooser.cs
Show resolved
Hide resolved
martinrrm
reviewed
May 15, 2025
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/VersionChooser.cs
Show resolved
Hide resolved
nkolev92
reviewed
May 15, 2025
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/DGSpecFactory.cs
Show resolved
Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/DGSpecFactory.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/PackageUpdateCommandRunner.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/PackageUpdateCommandRunner.cs
Outdated
Show resolved
Hide resolved
zivkan
commented
May 16, 2025
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/PackageUpdateCommandRunner.cs
Show resolved
Hide resolved
jeffkl
previously approved these changes
May 19, 2025
donnie-msft
requested changes
May 19, 2025
Contributor
donnie-msft
left a comment
There was a problem hiding this comment.
Requesting changes only for the localized String questions/suggestions.
Overall, looks great and I'm wondering if there's some reuse for the VS update command here in the future.
test/NuGet.Core.FuncTests/Dotnet.Integration.Test/DotnetPackageUpdateTests.cs
Show resolved
Hide resolved
test/NuGet.Core.FuncTests/Dotnet.Integration.Test/DotnetPackageUpdateTests.cs
Show resolved
Hide resolved
test/NuGet.Core.FuncTests/Dotnet.Integration.Test/DotnetPackageUpdateTests.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/VersionChooser.cs
Outdated
Show resolved
Hide resolved
...uGet.CommandLine.XPlat/Commands/PackageReferenceCommands/AddPackageReferenceCommandRunner.cs
Show resolved
Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/PackageUpdateCommandRunner.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/PackageUpdateCommandRunner.cs
Show resolved
Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/DGSpecFactory.cs
Show resolved
Hide resolved
nkolev92
previously approved these changes
May 19, 2025
Member
nkolev92
left a comment
There was a problem hiding this comment.
LGTM.
Donnie has some strings feedback, but after that 🚢 it.
jeffkl
approved these changes
May 20, 2025
nkolev92
approved these changes
May 20, 2025
donnie-msft
approved these changes
May 20, 2025
Contributor
donnie-msft
left a comment
There was a problem hiding this comment.
Localized string comments appear to be resolved now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14305
Description
dotnet package updatecommandNuGet.CommandLine.XPlat. The dotnet/sdk repo will need a change after this version of NuGet is inserted, in order to for the dotnet CLI to know that this command is available.dotnet package adddoes, except package add does the child process in the dotnet/sdk repo, while package update does it with code in the NuGet.Client repo. However, all of this is (hopefully) temporary. A few weeks ago I addedPackageSpecFactoryand one of the intended goals was to enable easily creating the DGSpec in-process in dotnet CLI commands (as well as consolodating the existing 4 PackageSpec creation methods into 1). However, to save time, this code is doing the child process for now.PR Checklist