Skip to content

Remove unnecessary source-build patch#5414

Merged
aortiz-msft merged 1 commit into
NuGet:devfrom
MichaelSimons:remove-sb-patch
Sep 20, 2023
Merged

Remove unnecessary source-build patch#5414
aortiz-msft merged 1 commit into
NuGet:devfrom
MichaelSimons:remove-sb-patch

Conversation

@MichaelSimons

@MichaelSimons MichaelSimons commented Sep 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Bug

Fixes: dotnet/source-build#3149

Regression? Last working version: N/A

Description

This source-build patch is no longer necessary as it was a workaround for an arcade issue that has since been addressed - dotnet/arcade#7549

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A

  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@MichaelSimons MichaelSimons requested a review from a team as a code owner September 20, 2023 17:47
@ghost ghost added the Community PRs created by someone not in the NuGet team label Sep 20, 2023
@MichaelSimons MichaelSimons mentioned this pull request Sep 20, 2023
Closed
@MichaelSimons

MichaelSimons commented Sep 20, 2023

Copy link
Copy Markdown
Contributor Author

@nkolev92 - This is needed for .NET 8.0, will change made in the dev branch flow into .NET 8.0? TIA

@MichaelSimons MichaelSimons mentioned this pull request Sep 20, 2023
Closed
5 tasks
@nkolev92

nkolev92 commented Sep 20, 2023

Copy link
Copy Markdown
Member

@nkolev92 - This is needed for .NET 8.0, will change made in the dev branch flow into .NET 8.0? TIA

Yep, dev is still targeting NET8.0.

cc @aortiz-msft to add a Merge this release label. This is just infrastructure.

@aortiz-msft aortiz-msft merged commit 1a85afa into NuGet:dev Sep 20, 2023
@nkolev92

nkolev92 commented Sep 21, 2023

Copy link
Copy Markdown
Member

The source build leg failed, https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8423365&view=logs&j=cb98efd6-7062-56ef-f642-0176540bbe0a, is that expected @MichaelSimons

@MichaelSimons

MichaelSimons commented Sep 21, 2023

Copy link
Copy Markdown
Contributor Author

The source build leg failed, https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8423365&view=logs&j=cb98efd6-7062-56ef-f642-0176540bbe0a, is that expected @MichaelSimons

No it wasn't intentional. Looks like I needed to update the arcade version as well as it is old and missing the fix I referenced earlier. Will open another PR.

@MichaelSimons MichaelSimons mentioned this pull request Sep 21, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nkolev92 nkolev92 nkolev92 approved these changes

Assignees

No one assigned

Labels

Community PRs created by someone not in the NuGet team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[VMR] nuget-client build fails on case-preserving filesystems (Mac, Windows)

3 participants

@MichaelSimons @nkolev92 @aortiz-msft