Show Vulnerable label in versions combobox#5185
Conversation
|
@martinrrm could you try shrinking the details pane to its min size and let us know how's the wrapping? PLOC testing would be ideal, including with minimum supported screen resolution. You can be the first to try my PLOC testing guide (you're welcome :D) Also, I imagine this string works fine but please test with AccessibilityInsights and Narrator to ensure 'Vulnerable' and 'Vulnerable, Deprecated' are announced appropriately. |
|
Tested Narrator and AccessibilityInsights, both passed 🎉 |
|
|
donnie-msft
left a comment
There was a problem hiding this comment.
Thanks for doing the PLOC & A11y testing.
It'd be great if a separate PR could add tests to DetailControlModelTests to hit some edge cases. Ideally that would happen in 17.7 Preview 2 or 3.
|
@donnie-msft Added Accessibility Insights results |
Bug
Fixes: NuGet/Home#11127
Regression? Last working version:
Description
Added a label to the versions combobox to show when a package is Vulnerable or Vulnerable and deprecated. (Deprecated label already exists).
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation