Fixes CA2213 issues on NuGet client repo (release-6.3.x)#4913
Merged
kartheekp-ms merged 1 commit intorelease-6.3.xfrom Nov 11, 2022
Merged
Fixes CA2213 issues on NuGet client repo (release-6.3.x)#4913kartheekp-ms merged 1 commit intorelease-6.3.xfrom
kartheekp-ms merged 1 commit intorelease-6.3.xfrom
Conversation
nkolev92
reviewed
Nov 10, 2022
Member
nkolev92
left a comment
There was a problem hiding this comment.
Wouldn't this change technically introduce more risk? Can we just suppress the warning instead.
* suppress CA2213 to unblock dev * Adding TODO comment with bug number
01fecb7 to
f2b2096
Compare
Contributor
Author
Sure, we can do that. Cherry-picked c543930 commit. |
nkolev92
approved these changes
Nov 11, 2022
dominoFire
approved these changes
Nov 11, 2022
zivkan
approved these changes
Nov 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/1998
Tracking: NuGet/Home#12116
Regression? Last working version:
Description
Cherry-pick c543930 to suppress CI failures in
release-6.3.xbranch because PR build failed with the following error.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation