Use accessible Foreground on WatermarkedTextbox in Add Package Source Mapping dialog#4856
Merged
donnie-msft merged 1 commit intodevfrom Oct 17, 2022
Merged
Conversation
erdembayar
approved these changes
Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12141
Regression? Last working version:
Description
Until the VS Platform supports inheritance for this control, and rather than create our own WatermarkedTextbox, I've chosen to copy just the styles we need, and set an appropriate Foreground.
I've commented in XAML with the issue that contains context on when we can remove the styles and just use the Platform styles directly.
Before this PR:
After this PR:
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation