Bug

Fixes: https://github.com/NuGet/Client.Engineering/issues/1629

Regression? Last working version:

Description

This changes comes down to the functionality in NuGetPackageManager.
It is disjointed and it can be a bit challenging to find a spot to warn.

In the end, changes were needed in only 2 places, the preview install and update codepaths on a project level for packages.config projects only.

PackageReference projects warn by different means and uninstall scenarios in packages.config do not directly use any sources, but rather if need be, restore will be called.

You can use https://github.com/NuGet/Client.Engineering/issues/1523 for reference of all the scenarios I analyzed.
In addition to the automated tests, I validated manually that all scenarios warn correctly.

Here's the long description of my analysis of all NuGetPackageManager methods.

Execute Actions:

ExecuteBuildIntegratedProjectActionsAsync - We don't really need to handle build integrated. PackageReference projets raise warnings in different places

ExecuteNuGetProjectActionsAsync - We won't warn in execute project actions, we'll do it in previews only.
ExecuteNuGetProjectActionsAsync - We won't warn in execute project actions, we'll do it in previews only.
ExecuteNuGetProjectActionsAsync - We won't warn in execute project actions, we'll do it in previews only.

PreviewBuildIntegratedProjectActionsAsync - We don't really need to handle build integrated. PackageReference projets raise warnings in different places

Install:

InstallPackageAsync - Calls one of the other ones.
InstallPackageAsync - Calls one of the other ones.
InstallPackageAsync - Calls one of the other ones.
InstallPackageAsync - Calls one of the other ones.
InstallPackageAsync - Calls one of the other ones.
InstallPackageAsync - Calls one of the other ones.
InstallPackageAsync - Calls bottom one
InstallPackageAsync - Calls PreviewInstallPackageAsync

PreviewInstallPackageAsync - Calls bottom one
PreviewInstallPackageAsync - Calls bottom one
PreviewInstallPackageAsync - Calls bottom one
PreviewInstallPackageAsync - Should be the one warning.

PreviewProjectsInstallPackageAsync - Calls one of the PreviewInstallPackageAsync eventually ending up in the same. By warning in the last PreviewInstallPackageAsync, we'd be warning everywhere.

Update:

PreviewUpdatePackagesAsync - All of these call PreviewUpdatePackagesAsync private method.
PreviewUpdatePackagesAsync - All of these call PreviewUpdatePackagesAsync private method.
PreviewUpdatePackagesAsync - All of these call PreviewUpdatePackagesAsync private method.
PreviewUpdatePackagesAsync - All of these call PreviewUpdatePackagesAsync private method.

PreviewUpdatePackagesAsync splits into build integrated and non-buiild integrated
We will warn in PreviewUpdatePackagesForClassicAsync for each project individually.

Uninstall:

UninstallPackageAsync -> Calls the preview ones.

PreviewProjectsUninstallPackageAsync - Calls PreviewUninstallPackageInternalAsync eventually. The trick is that in packages.config scenarios, there's no feed usage in Uninstall flows. Potentially packages may be restored prior to that, but that'll warn through a different codepath.

PreviewUninstallPackageAsync -> both of these call PreviewUninstallPackageInternalAsync.
PreviewUninstallPackageAsync -> both of these call PreviewUninstallPackageInternalAsync.

Note that the tests in question are enough to cover all installation scenarios as the warning is being raised from NuGetPackageManager and all operations share that.

PR Checklist

• PR has a meaningful title

• PR has a linked issue.

• Described changes

• Tests

  • Automated tests added
  • OR
  • Test exception
  • OR
  • N/A

• Documentation

  • Documentation PR or issue filled
  • OR
  • N/A