Warn when http sources are used in list package#4629
Conversation
8f93a8b to
2e9e1a5
Compare
|
@JonDouglas @chgill-MSFT The message we have been using for all scenarios is:
As discussed in the meeting, we don't really have say Here's my first stab: Single source:
Multiple sources:
|
|
I like the single source and that you added the "action" to change to HTTP, but for the multiple sources, is it possible to do a multiline warning?
Something like that, I'm worried about readability when there are a lot of sources but given that users don't use a lot of |
|
I think the newline is a good idea. |
|
|
That looks good to me. Do you think we should use newlines for the multi source one? |
|
For sure. If we can organize these things more than on a single line, it would be more effective & glanceable. Fixed my original message as I didn't realize the intention till now. |
2e9e1a5 to
fd7871f
Compare
|
Pushed a change with the updated messages. |
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/1626
Regression? Last working version:
Description
Add a warning for http source usage in the dotnet list package command.
Sample output:
Note that the warn part is a functiion of the nuget.commandline.xplat and not my change.
I had to do some test work to make this testable.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation