Warn when http sources are used in search and list#4628
Merged
Conversation
a816e76 to
276d9f5
Compare
jeffkl
previously approved these changes
May 24, 2022
276d9f5 to
c65c3f5
Compare
Contributor
|
The test coverage looks great. How about adding a test for multiple sources scenario in |
Member
Author
|
Updated the error messages and added more tests. |
erdembayar
previously approved these changes
May 26, 2022
erdembayar
approved these changes
May 26, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/1625
Regression? Last working version:
Description
Enable warnings for nuget.exe list/search scenarios.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation