Skip to content

Add sources to NU1507 warning#4609

Merged
nkolev92 merged 2 commits intodevfrom
dev-jeffkl-add-sources-to-nu1507
May 10, 2022
Merged

Add sources to NU1507 warning#4609
nkolev92 merged 2 commits intodevfrom
dev-jeffkl-add-sources-to-nu1507

Conversation

@jeffkl
Copy link
Contributor

@jeffkl jeffkl commented May 3, 2022

Bug

Fixes: NuGet/Home#11715

Regression? No Last working version:

Description

Added the package source names to the NU1507 warning

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

Copy link
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One clarification
PackageSource.Name or PackageSource.Source, that is name vs url.

Co-authored-by: Fernando Aguilar <feaguila@microsoft.com>
@nkolev92 nkolev92 requested a review from dominoFire May 10, 2022 17:16
@nkolev92 nkolev92 merged commit b77d764 into dev May 10, 2022
@nkolev92 nkolev92 deleted the dev-jeffkl-add-sources-to-nu1507 branch May 10, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DCR]: Print sources in NU1507

3 participants