Warn when http sources are used in PackageReference restore operations#4556
Merged
Warn when http sources are used in PackageReference restore operations#4556
Conversation
kartheekp-ms
previously approved these changes
Apr 12, 2022
Contributor
kartheekp-ms
left a comment
There was a problem hiding this comment.
Maybe update the PR title saying this fix is specifically for PackageReference style projects.
Member
Author
|
Fixed the title, nice catch. |
jeffkl
previously approved these changes
Apr 13, 2022
f55fada to
ec08f53
Compare
kartheekp-ms
approved these changes
Apr 13, 2022
|
@nkolev92 We just hit this today, is there any official announcement or timeline about the HTTP deprecation? We've got an old server we'll be migrating off of in the near future and some concrete dates would help us with planning. |
|
Same here, could you please give the planned Visual Studio / NuGet release for which non-HTTPS access will be completely removed ? |
|
Please note also that there does not seem to be any help for NU1803 on the Microsoft docs pages (e.g. if you click on the NU1803 error from VisualStudio it results in an "Oops! No F1 help match was found" webpage) |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/1358
Regression? Last working version:
Description
Pretty straightforward. Contains the same warning as #4552, but obviously with a code since it's restore.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation