Conversation
| <packageSource key=""https://feed2""> | ||
| <package pattern=""baz"" /> | ||
| </packageSource> | ||
| </packageSourceMapping> |
There was a problem hiding this comment.
Is having more than 1 source is bad practice with central package management?
Still trying to understand why it's the issue.
There was a problem hiding this comment.
We want to make NuGet secure by default and in this case since the customer is using CPM, they should at least be told they can use package source mapping to be more secure.
79ea854 to
1281247
Compare
nkolev92
left a comment
There was a problem hiding this comment.
Change looks great, the test probably need cleaned up.
test/NuGet.Core.Tests/NuGet.Commands.Test/RestoreCommandTests.cs
Outdated
Show resolved
Hide resolved
1281247 to
7f7c115
Compare
|
Team Review: Decide if we want to allow the feeds that Visual Studio configures so that people don't get the warning from feeds configured not by them |
|
@NuGet/nuget-client please review again with the final wording of the warning, @aortiz-msft does this look good to you? |
a02f29b to
860b793
Compare
|
@NuGet/nuget-client Had to rebase to get a green build which reset approvals, @nkolev92 please approve again |
Bug
Fixes: NuGet/Home#11505
Regression? Last working version:
Description
Log a warning during restore if central package management is being used, there is more than one feed configured, and package source mapping is not enabled.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation