Conversation
|
@josesimoes it's rather challenging to test without a working SDK, but a quick test of packing a custom |
| StringComparison.OrdinalIgnoreCase) | ||
| || versionParts.Any(x => x > 9)) | ||
| || versionParts.Any(x => x > 9) | ||
| || string.Equals( |
There was a problem hiding this comment.
nit: Is it worth updating the comment above this line to include netnano?
|
@zivkan all right!!! Happy to test with my initial SDK version. |
|
I wished you asked on any other day. Our If you're on Windows, it should be 1. clone our repo, 2. run configure.ps1, 3. run build.ps1, but you probably want Assuming you need the .NET 5/Core build of NuGet.Frameworks.dll, I don't think it checks strong name keys. If you're running on .NET Framework, then you'll need to either run if hopefully this builds NuGet.Frameworks.dll, which you can then copy from |
|
@nkolev92 local build successful and I have the NuGet.Frameworks.dll! |
|
That's a very valid question :) I'd download a custom version of the SDK and put it literally anywhere. You can use And just copy NuGet.Frameworks in it, in a similar way like @zivkan shared. You can use this script (keep in mind, it uses some defaults such as Configuration) that helps you copy all the built nuget files, |
|
Nikolche's comments are about the .NET SDK, not your own .NET nanoFramework SDK. The principal is go to the directory for the .NET SDK you want to use, then in the I don't know how any SDK that adds target platforms that the .NET SDK doesn't support is supposed to work, so if the above doesn't help, I'm really not sure. The goal is just to replace the NuGet.Frameworks.dll in the .NET SDK that is used when your .NET nanoFramework SDK is used build a nano framework project. |
|
oh I totally misread that, thanks for clarifying it @zivkan. Adding to what Andy said, I don't think your SDK would need to depend on NuGet.Framework, it should only rely on the msbuild logic. |
|
Reporting back my testing on this. Following the instructions above:
Using the WIP nanoFramework SDK on a test project with that sdk I get the following (using csproj): And I'm also able to pack using nfproj format: Still need to tackle a few issues with the build tasks but it does look VERY promising! 🥳 🚀 Thank you soo much @zivkan and @nkolev92 for helping make this possible and, of course, for the guidance provided. 😃 |
|
I can see that this is on the current sprint. Just wanted to ask if there is any expected date to see it in a preview SDK? Thanks. |
|
It'll definitely be in the 6.0.300 SDK. Almost certainly in the first public preview, but it depends when the preview ships and when the .NET SDK set up their subscriptions to the .NET Engineering team's dependency flow orchestration system (Meastro/darc). 6.0.2xx is too close to release so now there's a high bar to allow new changes, so I just don't know if they'll accept this new TFM, even though I'd say the risk is very low. After an appropriate version of NuGet is inserted into the .NET SDK, it'll be available in their "nightly builds", so it won't be necessary to wait until the public preview. Once they create a 6.0.3xx branch, this will be the file that defines all the .NET SDK's dependencies: https://github.com/dotnet/sdk/blob/release/6.03xx/eng/Versions.props Search for NuGet, and as soon as NuGet's version number is 6.2.0-*, then the SDK will contain the appropriate version of NuGet. |



Bug
Fixes: NuGet/Home#10800
Regression? No
Description
Added .NETnanoFramework with short folder mapping
netnano, as per Immo's design in the linked issue.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation