add hook for disabling the default extensions in the build output by Anipik · Pull Request #3980 · NuGet/NuGet.Client

Anipik · 2021-04-01T23:22:11Z

Description

This msbuild flag allows user to edit the default file extensions included in the build output of the package. eg. it allows us to exclude the .xml files from the package.

Test are added for validation

cc @ViktorHofer @ericstj

Nirmal4G

Property Name suggestion...

src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.targets

test/NuGet.Core.FuncTests/Dotnet.Integration.Test/PackCommandTests.cs

nkolev92 · 2021-04-30T01:19:51Z

🔔 @Anipik

Anipik · 2021-04-30T17:48:49Z

i will try to get the tests in next week.

Anipik · 2021-05-19T17:54:06Z

@nkolev92 it seems like the ci is hung on this, do we need to do something ?

nkolev92 · 2021-05-19T18:18:31Z

@Anipik the CI for people without write access doesn't run automatically.

Kicked it off.

nkolev92 · 2021-05-19T19:15:41Z

@Anipik

There's some test failures. Can you access the following, check out the test table for partial results.

The tests that are failing are pack specific.

src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.targets

test/NuGet.Core.FuncTests/Dotnet.Integration.Test/PackCommandTests.cs

Anipik · 2021-05-20T17:30:52Z

@nkolev92 do we need to trigger the ci again here ?

erdembayar · 2021-05-21T21:20:46Z

@Anipik
I just trigged CI build. 🤞

Anipik · 2021-05-22T00:02:38Z

@erdembayar @nkolev92 the ci passed, can you merge it as well ?

erdembayar

I'll approve it now, but wait little bit before merge, let other people review too.

nkolev92

LGTM.

Anipik · 2021-05-24T16:44:52Z

hey @erdembayar @nkolev92 do we need something more here ?

erdembayar · 2021-05-24T17:22:08Z

hey @erdembayar @nkolev92 do we need something more here ?

@Anipik
Don't worry, I'll merge by lunch time if there is no one else comment.

Anipik · 2021-05-24T17:23:30Z

awesome thanks.

Anipik requested a review from a team as a code owner April 1, 2021 23:22

Nirmal4G reviewed Apr 2, 2021

View reviewed changes

src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.targets Outdated Show resolved Hide resolved

nkolev92 reviewed Apr 2, 2021

View reviewed changes

src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.targets Outdated Show resolved Hide resolved

zivkan added the Community PRs created by someone not in the NuGet team label Apr 5, 2021

zivkan assigned zkat Apr 5, 2021

nkolev92 reviewed Apr 6, 2021

View reviewed changes

test/NuGet.Core.FuncTests/Dotnet.Integration.Test/PackCommandTests.cs Outdated Show resolved Hide resolved

Anipik mentioned this pull request Apr 15, 2021

Port Microsoft.Extensions.* from pkgproj to dotnet pack dotnet/runtime#48385

Closed

ViktorHofer mentioned this pull request Apr 26, 2021

Add Infra for porting lib only packages to use dotnet pack instead of pkgprojs dotnet/runtime#51765

Merged

ericstj mentioned this pull request May 12, 2021

Add Analyzer packaging support and packaging documentation dotnet/runtime#52554

Merged

Anipik mentioned this pull request May 14, 2021

[Draft] Moving System.Diagnostics.Eventlog to csproj pack dotnet/runtime#52744

Closed

nkolev92 added the Approved for CI label May 19, 2021

erdembayar reviewed May 19, 2021

View reviewed changes

src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.targets Outdated Show resolved Hide resolved

erdembayar reviewed May 19, 2021

View reviewed changes

test/NuGet.Core.FuncTests/Dotnet.Integration.Test/PackCommandTests.cs Show resolved Hide resolved

nkolev92 added Approved for CI and removed Approved for CI labels May 20, 2021

Anipik added 7 commits May 20, 2021 14:31

add hook for disabling the default extensions

c556d95

generate the xml

9616ad9

remove condition typo

83d0513

fix the test

0ac402f

test specifically for .xml files

ec8a8f9

add . to extensions.

aeba243

doesnot contain check for all different extensions

424a9b0

erdembayar added Approved for CI and removed Approved for CI labels May 20, 2021

Anipik added 3 commits May 21, 2021 11:09

add dll and exe checks

69193af

still keep the xml to actually test for removal

4c036f9

add other extensions as well

fcf0742

erdembayar added Approved for CI and removed Approved for CI labels May 21, 2021

erdembayar approved these changes May 22, 2021

View reviewed changes

nkolev92 approved these changes May 22, 2021

View reviewed changes

erdembayar merged commit 25e7298 into NuGet:dev May 24, 2021

Anipik deleted the extension branch May 24, 2021 19:50

Conversation

Anipik commented Apr 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Nirmal4G left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nkolev92 commented Apr 30, 2021

Uh oh!

Anipik commented Apr 30, 2021

Uh oh!

Anipik commented May 19, 2021

Uh oh!

nkolev92 commented May 19, 2021

Uh oh!

nkolev92 commented May 19, 2021

Uh oh!

Uh oh!

Uh oh!

Anipik commented May 20, 2021

Uh oh!

erdembayar commented May 21, 2021

Uh oh!

Anipik commented May 22, 2021

Uh oh!

erdembayar left a comment

Choose a reason for hiding this comment

Uh oh!

nkolev92 left a comment

Choose a reason for hiding this comment

Uh oh!

Anipik commented May 24, 2021

Uh oh!

erdembayar commented May 24, 2021

Uh oh!

Anipik commented May 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Anipik commented Apr 1, 2021 •

edited

Loading