Skip to content

AssetTargetFallback is respected with dependency resolution#11460

Merged
nkolev92 merged 5 commits intodevfrom
dev-nkolev92-atfdepsDesign
Jan 28, 2022
Merged

AssetTargetFallback is respected with dependency resolution#11460
nkolev92 merged 5 commits intodevfrom
dev-nkolev92-atfdepsDesign

Conversation

@nkolev92
Copy link
Copy Markdown
Member

@nkolev92 nkolev92 commented Dec 16, 2021

Rendered - Remember to refresh as GH won't prompt you for updates.

Design for #5957

PR in NuGet.Client - NuGet/NuGet.Client#4372

@nkolev92 nkolev92 force-pushed the dev-nkolev92-atfdepsDesign branch from 927fba7 to 99f4e58 Compare December 17, 2021 22:00
@nkolev92 nkolev92 marked this pull request as ready for review December 17, 2021 22:02
@nkolev92 nkolev92 requested a review from a team as a code owner December 17, 2021 22:02
@nkolev92 nkolev92 requested a review from a team December 17, 2021 22:04
@nkolev92
Copy link
Copy Markdown
Member Author

nkolev92 commented Jan 8, 2022

@NuGet/nuget-client I'd appreciate a review here.

I'll schedule a meeting to discuss this.

Copy link
Copy Markdown
Member

@zivkan zivkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how long ago I made these comments, but GitHub remembered them, so I'm posting them now.

@nkolev92 nkolev92 requested a review from zivkan January 28, 2022 02:57
@nkolev92
Copy link
Copy Markdown
Member Author

@nuget/nuget-client

Updated the design based on the discussion.

Can someone please approve so I can merge.

@nkolev92 nkolev92 merged commit e2de263 into dev Jan 28, 2022
@nkolev92 nkolev92 deleted the dev-nkolev92-atfdepsDesign branch January 28, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants