-
Notifications
You must be signed in to change notification settings - Fork 268
Remove or improve configuration change events #8479
Copy link
Copy link
Open
Labels
Category:Quality WeekIssues that should be considered for quality weekIssues that should be considered for quality weekFunctionality:SDKThe NuGet client packages published to nuget.orgThe NuGet client packages published to nuget.orgPriority:2Issues for the current backlog.Issues for the current backlog.Product:VS.ClientTechDebtTechnical debtTechnical debtType:Bug
Metadata
Metadata
Assignees
Labels
Category:Quality WeekIssues that should be considered for quality weekIssues that should be considered for quality weekFunctionality:SDKThe NuGet client packages published to nuget.orgThe NuGet client packages published to nuget.orgPriority:2Issues for the current backlog.Issues for the current backlog.Product:VS.ClientTechDebtTechnical debtTechnical debtType:Bug
Type
Fields
Give feedbackNo fields configured for issues without a type.
ISettingsandIPackageSourceProviderhave events about changes to settings. However, the only place this appears to be used is inExtensibleSourceRespositoryProviderand the only place it appears to be raised is inVSSettingswhen solutions are opened or closed.The easier option would be to make
ExtensibleSourceRespositoryProvidersubscribe to the solution open and close events directly and remove all the configuration event code.Alternatively, events should be unsubscribed properly, probably by making everything related
IDisposableand making sure they get disposed correctly.