-
Notifications
You must be signed in to change notification settings - Fork 269
Closed
NuGet/NuGet.Client
#4778Labels
Functionality:VisualStudioUIPackage Manager UI et alPackage Manager UI et alPriority:2Issues for the current backlog.Issues for the current backlog.Product:VS.ClientType:Engineeringproduct/infrastructure work/not a customer bug/feature/DCRproduct/infrastructure work/not a customer bug/feature/DCR
Milestone
Description
The purpose of our VsDialogWindow.cs appears to be that, in the past, the VS platform assembly name was revved for each product iteration, meaning our XAML code needed a wrapper to target the correct assembly without specifying the version# in XAML.
The version is no longer being revved for Microsoft.VisualStudio.Shell.15.0.dll, so I believe this can be removed entirely. We also have other direct XAML references to this assembly already (eg, InfiniteScrollList.xaml).
I found a comment here that makes me more confident that this is safe to remove:
/// <summary> /// Works around an issue w/ DialogWindow and targetting multiple versions of VS. /// /// Because the Microsoft.VisualStudio.Shell.version.0 assembly changes names /// we cannot refer to both v10 and v11 versions from within the same XAML file. /// Instead we use this subclass defined in our assembly. /// </summary>
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Functionality:VisualStudioUIPackage Manager UI et alPackage Manager UI et alPriority:2Issues for the current backlog.Issues for the current backlog.Product:VS.ClientType:Engineeringproduct/infrastructure work/not a customer bug/feature/DCRproduct/infrastructure work/not a customer bug/feature/DCR
Type
Fields
Give feedbackNo fields configured for issues without a type.