Skip to content

GetReferenceNearestTargetFrameworkTask should not log params when LogTaskInputs is set #10696

Closed
NuGet/NuGet.Client
#5498
Closed
GetReferenceNearestTargetFrameworkTask should not log params when LogTaskInputs is set#10696
NuGet/NuGet.Client
#5498
Labels
Area:LoggingFunctionality:RestorePriority:3Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog.Resolution:BlockedByExternalProgress on this task is blocked by an external issue. When that issue is completed this can proceedType:Bug
Milestone
6.9
@KirillOsenkov

Description

@KirillOsenkov
KirillOsenkov
opened on Mar 26, 2021

When MSBuild sets LogTaskInputs, there's no need to specifically log task inputs or outputs as MSBuild will take care of that.

See here:
https://github.com/NuGet/NuGet.Client/blob/58fd22bfc941a6d5cc9404f41a583efb4dfeeaf0/src/NuGet.Core/NuGet.Build.Tasks/GetReferenceNearestTargetFrameworkTask.cs#L64

See dotnet/msbuild#6305 for guidance. Otherwise there's duplication, allocations, log bloat:
image

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area:LoggingFunctionality:RestorePriority:3Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog.Resolution:BlockedByExternalProgress on this task is blocked by an external issue. When that issue is completed this can proceedType:Bug

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions